Pipits Inline Perch Assets problem

tidygraphic · Feb 25th 2021

Good afternoon,

I'd love to use the Pipits Inline Perch Assets on a new site I'm working on but I can't seem to get it to work. I have custom Redactor plugins loading and working fine but adding the Inline Assets plugin doesn't seem to work. I can get the icon to appear but adding an image simply adds a blank line within Redactor and no image.

In the console I end up with Unhandled Promise Rejection: SyntaxError: The string did not match the expected pattern after trying to add an image using the plugin (using Safari, Big Sur).

My Redactor config.js code is below and I'm on the latest version of Perch Runway:

Code

Perch.UserConfig.redactor = function () {
var get = function (profile, config, field) {
// remove perchassets plugin
config.plugins = config.plugins.filter(function (item) {
return item !== 'perchassets'
})
// add inlineperchassets plugin
if (config.plugins.indexOf('inlineperchassets') === -1) config.plugins.push('inlineperchassets');
if (config.plugins.indexOf('table') === -1) config.plugins.push('table');
if (config.plugins.indexOf('video') === -1) config.plugins.push('video');
if (config.plugins.indexOf('specialchars') === -1) config.plugins.push('specialchars');
if (config.plugins.indexOf('definedlinks') === -1) {
config.plugins.push('definedlinks');
config.definedlinks = Perch.path + '/addons/plugins/editors/page-links/page-list.php';
}
if (!config.linkNewTab) {
config.linkNewTab = true;
}
if (!config.formattingAdd) {
config.formattingAdd = {
'bold': {
title: 'Bold Paragraph',
api: 'module.block.format',
args: {
'tag': 'p',
'class': 'c-leading'
},
'type': 'toggle'
},
};
}
config.buttonsAdd = ['line']
if(profile == 'minimal') {
// hide some buttons
config.buttons = ['bold', 'italic', 'link']
// hides Perch assets plugin
config.plugins = ['definedlinks', 'specialchars']
}
// Needed when using minimal win combination with other styles
if(profile == 'expanded') {
config.buttons = ['html', 'format', 'bold', 'italic', 'lists', 'link', 'file']
// hides Perch assets plugin
config.plugins = ['definedlinks', 'specialchars']
}
return config;
};
var load = function(cb) {
$("<style/>").text('.redactor-styles .c-leading { font-size: 16px; font-weight: bold; }').appendTo(document.head);
jQuery.getScript(Perch.path + '/addons/plugins/editors/redactor-plugins/pipit_inlineperchassets/inlineperchassets.js', function(){
jQuery.getScript(Perch.path + '/addons/plugins/editors/redactor-plugins/table.js', function(){
jQuery.getScript(Perch.path + '/addons/plugins/editors/page-links/definedlinks.js', function() {
jQuery.getScript(Perch.path + '/addons/plugins/editors/redactor-plugins/video.js', function() {
jQuery.getScript(Perch.path + '/addons/plugins/editors/redactor-plugins/specialchars.js', cb);
});
});
});
});
};
return {
'get': get,
'load': load
}
}();

Display More

Would love it if Hussein is around and can shed any light on what might be wrong.

Thanks, Lea.

hus_hmd · Feb 25th 2021

Hi Lea,

I'll be happy to help.

Does this only happen in Safari?
Does this happen when adding an existing asset or a newly uploaded one? Or both?
Does the issue still happen if you remove the other plugins?

tidygraphic · Feb 25th 2021

Thanks Hussein - some answers for you:

I tested in Chrome as I thought that could be the case and I received a similar error message but referencing JSON. I can dig this out if it helps?
Seems to be for new or existing assets
I added your example config just to check this and still had the same result

I'll try this out on our staging server tomorrow to see if I can find any more information.

Thanks for getting back to me.

hus_hmd · Feb 25th 2021

Quote from tidygraphic

I tested in Chrome as I thought that could be the case and I received a similar error message but referencing JSON. I can dig this out if it helps?

This is probably the issue. Unsure why exactly it is not working for you as I have used this on multiple sites without an issue. I'll look into it and report back.

tidygraphic · Feb 26th 2021

Hi Hussein,

I've cracked it - as you mentioned, as usual Chrome has the key. So - the console error lead me to a 404 with this require path require (realpath(__DIR__ . '/../../../..//') . '/core/runtime/runtime.php'); inside 'get_asset.php'. I've changed that line to read:

require ($_SERVER['DOCUMENT_ROOT'].'/admin/core/runtime/runtime.php');

Inline assets are now working a treat

Thanks for giving me a nudge in the right direction.

Thanks, Lea.

hus_hmd · Feb 26th 2021

Ah great! Thank you, Lea.

It's so weird of me to use `realpath` there! I'll update and publish a new release. I've opened an issue on GitHub (https://github.com/Pipits/reda…ine-perch-assets/issues/2), so hopefully I won't forget!