FATAL ERROR perch_shop_order - error displaying order if product is deleted from catalog after order is placed.

tonyastley · May 12th 2020

When displaying an order using:

PHP

<?php
perch_shop_order($orderID, [
'template' => '/shop/orders/order.html'
]);
?>

If the product is deleted from the catalog the order returns a fatal error:

Fatal error: Uncaught Error: Call to a member function to_array() on boolean in /pathto/site-folder/kpanel/addons/apps/perch_shop/lib/PerchShop_Order.class.php:538 Stack trace: #0 /pathto/site-folder/kpanel/addons/apps/perch_shop/lib/PerchShop_Order.class.php(393): PerchShop_Order->format_invoice_for_template(Array) #1 /pathto/site-folder/kpanel/addons/apps/perch_shop/lib/PerchShop_Order.class.php(402): PerchShop_Order->get_for_template() #2 /pathto/site-folder/kpanel/addons/apps/perch_shop/lib/PerchShop_Runtime.class.php(765): PerchShop_Order->template(Array) #3 /pathto/site-folder/kpanel/addons/apps/perch_shop/runtime/orders.php(62): PerchShop_Runtime->get_order_items(Array) #4 /pathto/site-folder/kpanel/templates/pages/shop/account/orders.php(8): perch_shop_order('16', Ar in /pathto/site-folder/kpanel/addons/apps/perch_shop/lib/PerchShop_Order.class.php on line 538

Oddly the order information displays OK in the admin area, it just throws an error on the front end - obviously the customer will need to be able to reference historic orders, even for products that have since been deleted.

Can this be fixed?

Byron Fitzgerald · May 12th 2020

Looks like the Order with the ID your are using doesn't exists yet when you are calling the shop function, have you verified the ID is correct. If so do you mind sharing the full page with us?

tonyastley · May 12th 2020

Hello Byron, thanks for the response.

The orders are historic orders, they show OK in the admin area, and you can see the ID of the order from the admin OK.

New orders placed work perfectly fine - until the product or variant within the order is deleted, they then show the same fatal error.

I'll include the page anyway for you. You can ignore the shipping and billing stuff, I had to jump through hoops to show that on the order .

PHP

<?php
$orderID = perch_get('orderID');
$order_id = perch_shop_successful_order_id();
$billingID = perch_shop_order($orderID, [
'template' => '/shop/orders/billingID.html'
], true);
$shippingID = perch_shop_order($orderID, [
'template' => '/shop/orders/shippingID.html'
], true);
$billingAddress = perch_shop_customer_address($billingID, [], true);
$shippingAddress = perch_shop_customer_address($shippingID, [], true);
PerchSystem::set_var('billingAddress', $billingAddress);
PerchSystem::set_var('shippingAddress', $shippingAddress);
$pageType = 'orderPage';
$pageTitle = empty($orderID) ? 'Your Orders' : 'Your Order' ;
PerchSystem::set_var('pageTitle', $pageTitle);
perch_layout('siteHead', array(
'pageType' => $pageType,
'pageTitle' => $pageTitle,
));
?>
<div class="wrapper">
<h1><?php echo $pageTitle ?></h1>
<?php if(empty($orderID)): ?>
<?php
perch_shop_orders([
'sort' => 'orderID',
'sort-order' => 'DESC',
]);
?>
<?php else: ?>
<p><a href="/shop/account/orders" title="View all orders..." class="viewAll">< View all orders...</a></p>
<?php
perch_shop_order($orderID, [
'template' => '/shop/orders/order_better.html'
]);
?>
<?php endif; ?>
</div>
<?php
perch_layout('siteFoot', array(
));
?>

Display More

Here is order_better.html:

Code

<div class="orderSummary">
<div class="orderMeta">
<div>
<h6>Order ID</h6>
<p><perch:shop id="orderID" /></p>
</div>
<div>
<h6>Invoice Number</h6>
<p><perch:shop id="invoice_number" /></p>
</div>
<div>
<h6>Date</h6>
<p><perch:shop id="orderCreated" type="date" format="d F Y H:i" /></p>
</div>
<div>
<h6>Status</h6>
<p><perch:shop id="orderStatus" format="UC" /></p>
</div>
</div>
<div class="orderList">
<h6>Order Summary</h6>
<perch:orderitems>
<div class="listItem">
<p><sku><perch:orderitem id="sku" /></sku>
<strong><perch:orderitem id="title" /></strong><br>
<span><variant><perch:orderitem id="variant_desc" /></variant><br>
Qty: <perch:orderitem id="quantity" /></span></p>
</div>
</perch:orderitems>
<div class="totals">
<perch:if id="total_discounts" match="gt" value="0.00">
<p>Discounts: <perch:shop id="total_discounts_formatted" /></p>
<p>Total: <perch:shop id="total_items_discounted_formatted" /></p>
<perch:else />
<p>Total: <perch:shop id="total_items_formatted" /></p>
</perch:if>
<p>Tax: <perch:shop id="total_tax_formatted" /></p>
<p>Grand Total: <perch:shop id="grand_total_formatted" /></p>
</div>
</div>
<div class="orderAddress">
<h6>Billing Address</h6>
<perch:shop id="billingAddress" html="true" />
</div>
<div class="orderAddress">
<h6>Shipping Address</h6>
<perch:shop id="shippingAddress" html="true" />
</div>
</div>

Display More

tonyastley · May 12th 2020

This part of debug has me worried this will require a fix from Drew as the system looks for the product ID and checks deletion, but something isn't working correctly:

SELECT * FROM perch3_shop_customers WHERE memberID=3

[1] SELECT * FROM perch3_shop_orders WHERE customerID=3 AND orderID=21 AND orderStatus IN ('paid', 'processing', 'cancelled', 'dispatched', 'returned', 'partial_refund', 'refunded')

[2] SELECT * FROM perch3_shop_order_items WHERE orderID='21' ORDER BY itemID ASC

[1] SELECT * FROM perch3_shop_order_statuses WHERE statusKey='paid' AND statusDeleted IS NULL LIMIT 1

[1] SELECT * FROM perch3_shop_currencies WHERE currencyID=47 LIMIT 1

[1] SELECT * FROM perch3_shop_shippings WHERE shippingID=4 AND shippingDeleted IS NULL LIMIT 1

[1] SELECT * FROM perch3_shop_products WHERE productID=144 AND productDeleted IS NULL LIMIT 1

[1] SELECT * FROM perch3_shop_currencies WHERE currencyActive=1 AND currencyID=47

[1] SELECT promoID FROM perch3_shop_order_promotions WHERE orderID=21

[1] SELECT * FROM perch3_shop_promotions WHERE promoID=1 LIMIT 1

[1] Using template: /templates//shop/orders/order_better.html

Mxkert · May 12th 2020

Can't you set the product's status to inactive instead of deleting it?

Byron Fitzgerald · May 12th 2020

Ok from checking the checking the core code this is where the error happens

Code

$item = array_merge($item, $Product->to_array());

So I'm guessing the product for one of the orders no longer exists. I think you said you regenerated your variants yesterday? The order could be looking for an old product variant that no longer exists.

tonyastley · May 12th 2020

Setting the products to inactive is an option, but has the following issues:

Sometimes a product simply has to be removed at the clients request (ease of updating etc).
Sometimes a product is mistakenly deleted by the clients admin.

As mentioned the orders display perfectly in the back end, could the same code from /addons/apps/perch_shop_orders/modes/order.detail.post.php be repurposed for the perch_shop_order function?

Byron Fitzgerald · May 12th 2020

You can always use the factory methods PerchShop_Orders, PerchShop_Products and which ever other classes you need. Each Base class will have a method to_array() which you can the pass to `perch_template('path_to_template', $array)`. For just the order info for example you could do the following

PHP

<?php $OrderFactory = new PerchShop_Orders();
$order = $OrderFactory->find($orderID);
perch_template('/shop/orders/order_better.html', $order);

Unfortunately with this method you lose the additional template handlers, so you can't use `<perch:cartitems>`.

tonyastley · May 12th 2020

Hello Byron,

I tried that method above and it retried the error:

Non-array content value passed to perch_template.

Is there something Im missing?

Byron Fitzgerald · May 12th 2020

Ah apologies forgot to add the to_array method

PHP

<?php $OrderFactory = new PerchShop_Orders();
$order = $OrderFactory->find($orderID);
$order = $order->to_array();
perch_template('/shop/orders/order_better.html', $order);

tonyastley · May 12th 2020

Thanks Byron, it doesn't look like that will be the solution for me. Looking into the showall it appears none of the products ordered are available to display.